Skip to content

[WIP] gh-116417: Move limited C API tests to _testlimitedcapi #116567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[WIP] gh-116417: Move limited C API tests to _testlimitedcapi #116567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3b01457
gh-116417: Move limited C API tests to _testlimitedcapi
vstinner Mar 7, 2024
5761f80
unicode.c
vstinner Mar 10, 2024
2c984f6
lower Py_LIMITED_API
vstinner Mar 10, 2024
0354b84
long.c
vstinner Mar 10, 2024
916dc57
AC: don't use PyFloat_AS_DOUBLE() with limited C API
vstinner Mar 10, 2024
422c188
float.c
vstinner Mar 10, 2024
12e8040
Update test_bytes, test_class, test_codecs
vstinner Mar 10, 2024
3bc12e7
Fix Free Threading build
vstinner Mar 10, 2024
bd8c80f
Update PCbuild
vstinner Mar 10, 2024
1521eaa
Fix typo
vstinner Mar 10, 2024
9684370
Fix make check-c-globals
vstinner Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Lib/test/test_bytes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,13 +991,13 @@ def test_translate(self):
self.assertEqual(c, b'hllo')

def test_sq_item(self):
_testcapi = import_helper.import_module('_testcapi')
_testlimitedcapi = import_helper.import_module('_testlimitedcapi')
obj = self.type2test((42,))
with self.assertRaises(IndexError):
_testcapi.sequence_getitem(obj, -2)
_testlimitedcapi.sequence_getitem(obj, -2)
with self.assertRaises(IndexError):
_testcapi.sequence_getitem(obj, 1)
self.assertEqual(_testcapi.sequence_getitem(obj, 0), 42)
_testlimitedcapi.sequence_getitem(obj, 1)
self.assertEqual(_testlimitedcapi.sequence_getitem(obj, 0), 42)


class BytesTest(BaseBytesTest, unittest.TestCase):
Expand Down Expand Up @@ -1256,7 +1256,7 @@ class SubBytes(bytes):
class ByteArrayTest(BaseBytesTest, unittest.TestCase):
type2test = bytearray

_testcapi = import_helper.import_module('_testcapi')
_testlimitedcapi = import_helper.import_module('_testlimitedcapi')

def test_getitem_error(self):
b = bytearray(b'python')
Expand Down Expand Up @@ -1354,7 +1354,7 @@ def setitem_as_mapping(b, i, val):
b[i] = val

def setitem_as_sequence(b, i, val):
self._testcapi.sequence_setitem(b, i, val)
self._testlimitedcapi.sequence_setitem(b, i, val)

def do_tests(setitem):
b = bytearray([1, 2, 3])
Expand Down Expand Up @@ -1401,7 +1401,7 @@ def del_as_mapping(b, i):
del b[i]

def del_as_sequence(b, i):
self._testcapi.sequence_delitem(b, i)
self._testlimitedcapi.sequence_delitem(b, i)

def do_tests(delete):
b = bytearray(range(10))
Expand Down Expand Up @@ -1810,7 +1810,7 @@ def __index__(self):
with self.subTest("tp_as_sequence"):
b = bytearray(b'Now you see me...')
with self.assertRaises(IndexError):
self._testcapi.sequence_setitem(b, 0, Boom())
self._testlimitedcapi.sequence_setitem(b, 0, Boom())


class AssortedBytesTest(unittest.TestCase):
Expand Down
Loading