-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
gh-113308: Remove some internal parts of uuid
module
#115934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1b8a3ad
gh-113308: Deprecate some internal parts of `uuid` module
sobolevn c198931
Address review
sobolevn 6bea9fc
Do not import `_uuid` twice
sobolevn 48ed729
Merge branch 'main' into issue-113308
sobolevn ee231d3
Change the PR to remove these internal parts instead
sobolevn 967c59b
Fix CI
sobolevn 10dc8c2
Also remove `has_uuid_generate_time_safe` from `_uuid` module
sobolevn df762ec
Revert "Also remove `has_uuid_generate_time_safe` from `_uuid` module"
sobolevn 0eec764
Update Lib/test/test_uuid.py
sobolevn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2024-02-26-10-06-50.gh-issue-113308.MbvOFt.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Remove some internal protected parts from :mod:`uuid`: | ||
``_has_uuid_generate_time_safe``, ``_netbios_getnode``, | ||
``_ipconfig_getnode``, and ``_load_system_functions``. | ||
They were unused. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.