-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
Docs: mark up FTP.retrbinary and FTP.storbinary with param lists #114399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
erlend-aasland
merged 4 commits into
python:main
from
erlend-aasland:docs/ftplib/stor-retr-binary
Jan 23, 2024
Merged
Docs: mark up FTP.retrbinary and FTP.storbinary with param lists #114399
erlend-aasland
merged 4 commits into
python:main
from
erlend-aasland:docs/ftplib/stor-retr-binary
Jan 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
commented
Jan 21, 2024
erlend-aasland
commented
Jan 21, 2024
erlend-aasland
commented
Jan 21, 2024
erlend-aasland
commented
Jan 21, 2024
Mark up integer literals using double backticks Co-authored-by: Ezio Melotti <[email protected]>
Co-authored-by: Ezio Melotti <[email protected]>
Ezio's remarks have been addressed. I'm going to land this tomorrow. |
hugovk
approved these changes
Jan 23, 2024
@@ -45,7 +45,6 @@ Doc/library/enum.rst | |||
Doc/library/exceptions.rst | |||
Doc/library/faulthandler.rst | |||
Doc/library/fcntl.rst | |||
Doc/library/ftplib.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🧹 📖 🎈
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2024
…honGH-114399) (cherry picked from commit 5277d4c) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2024
…honGH-114399) (cherry picked from commit 5277d4c) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
GH-114483 is a backport of this pull request to the 3.12 branch. |
GH-114484 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
added a commit
that referenced
this pull request
Jan 23, 2024
…ts (GH-114399) (#114483) (cherry picked from commit 5277d4c) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
Jan 23, 2024
…ts (GH-114399) (#114484) (cherry picked from commit 5277d4c) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…hon#114399) Co-authored-by: Ezio Melotti <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…hon#114399) Co-authored-by: Ezio Melotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--114399.org.readthedocs.build/