Docs: mark up FTP.connect() and FTP.login() with param lists #114395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
added
skip issue
skip news
needs backport to 3.11
erlend-aasland
commented
Jan 21, 2024
|
Digression: the ftplib API feels a little bit weird to use. I'd expected something a la the sqlite3 module: a module level |
Co-authored-by: Ezio Melotti <[email protected]>
|
Thanks, Ezio! |
|
Ezio's remarks have been addressed. I'm going to land this tomorrow. |
hugovk
approved these changes
Jan 23, 2024
Co-authored-by: Hugo van Kemenade <[email protected]>
|
Thanks, both! |
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2024
…H-114395) Use rst substitutions to reduce raw text duplication. (cherry picked from commit 01105c7) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 23, 2024
…H-114395) Use rst substitutions to reduce raw text duplication. (cherry picked from commit 01105c7) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-114485 is a backport of this pull request to the 3.12 branch. |
|
GH-114486 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
added a commit
that referenced
this pull request
Jan 23, 2024
…H-114395) (#114486) Use rst substitutions to reduce raw text duplication. (cherry picked from commit 01105c7) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
erlend-aasland
added a commit
that referenced
this pull request
Jan 23, 2024
…H-114395) (#114485) Use rst substitutions to reduce raw text duplication. (cherry picked from commit 01105c7) Co-authored-by: Erlend E. Aasland <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…114395) Use rst substitutions to reduce raw text duplication. Co-authored-by: Ezio Melotti <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…114395) Use rst substitutions to reduce raw text duplication. Co-authored-by: Ezio Melotti <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--114395.org.readthedocs.build/