Skip to content

gh-111724: Fix doctest ResourceWarning in howto/descriptor.rst #111725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 4, 2023

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Nov 4, 2023
@sobolevn sobolevn marked this pull request as ready for review November 4, 2023 09:06
@erlend-aasland
Copy link
Contributor

Backport to 3.12 and possibly 3.11?

@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 4, 2023
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@erlend-aasland erlend-aasland merged commit f48e669 into python:main Nov 4, 2023
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 4, 2023
…st` (pythonGH-111725)

Close database connection explicitly in test cleanup.
(cherry picked from commit f48e669)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 4, 2023
…st` (pythonGH-111725)

Close database connection explicitly in test cleanup.
(cherry picked from commit f48e669)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 4, 2023

GH-111727 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 4, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 4, 2023

GH-111728 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 4, 2023
terryjreedy pushed a commit that referenced this pull request Nov 4, 2023
…rst` (GH-111725) (#111727)

gh-111724: Fix doctest `ResourceWarning` in `howto/descriptor.rst` (GH-111725)

Close database connection explicitly in test cleanup.
(cherry picked from commit f48e669)

Co-authored-by: Nikita Sobolev <[email protected]>
terryjreedy pushed a commit that referenced this pull request Nov 4, 2023
…rst` (GH-111725) (#111728)

gh-111724: Fix doctest `ResourceWarning` in `howto/descriptor.rst` (GH-111725)

Close database connection explicitly in test cleanup.
(cherry picked from commit f48e669)

Co-authored-by: Nikita Sobolev <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…st` (python#111725)

Close database connection explicitly in test cleanup.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…st` (python#111725)

Close database connection explicitly in test cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants