Enable most pyflakes rules when running ruff on Lib/test in CI
#110917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Oct 16, 2023
| @@ -1429,7 +1429,6 @@ def equivalent_python(byte_array, byteorder, signed=False): | |||
| b'\x01\xff': -255, | |||
| b'\x00\xff': -256, | |||
| b'\xff\x00': 255, | |||
| b'\x00\x01': 256, | |||
hugovk
approved these changes
Oct 16, 2023
|
Adding DO-NOT-MERGE for now. This PR probably warrants discussion on Discourse before merging, since it's possible this could disrupt other core devs' workflows if they're unfamiliar with ruff |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff's pyflakes rules generally have very few false-positive errors; I think we generally should aim to have as many enabled in CI as is practical. With the exception of a few rules that currently have many hits when enabled on our test suite, this PR enables the full suite of pyflakes rules when running ruff on
Lib/test/.