Skip to content

gh-109795: _thread.start_new_thread: allocate thread bootstate using raw memory allocator #109808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 25, 2023
Merged

gh-109795: _thread.start_new_thread: allocate thread bootstate using raw memory allocator #109808

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4e1d6df
_thread.start_new_thread: allocate/free thread bootstate using raw me…
chgnrdv Sep 24, 2023
9665998
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 24, 2023
9b32580
Update 2023-09-24-22-26-56.gh-issue-109795.gI7KW6.rst
chgnrdv Sep 24, 2023
e5c0f92
added comment that refers the changes
chgnrdv Sep 25, 2023
b2f5e37
Merge branch '_thread-start-new-thread-use-raw-malloc-for-bootstate' …
chgnrdv Sep 25, 2023
0fdd943
Update Modules/_threadmodule.c
chgnrdv Sep 25, 2023
7c776a7
Merge branch 'main' into _thread-start-new-thread-use-raw-malloc-for-…
chgnrdv Sep 25, 2023
1d9c95a
Delete Misc/NEWS.d/next/Core and Builtins/2023-09-24-22-26-56.gh-issu…
chgnrdv Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-09-24-22-26-56.gh-issue-109795.gI7KW6.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:func:`!_thread.start_new_thread` now uses raw memory allocator to allocate new thread bootstate. This helps to avoid crashes in case when new thread gets started at interpreter finalization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Please remove this Changelog entry. I don't think that it's worth it. It doesn't impact directly users and it's a recent regression, no?

6 changes: 3 additions & 3 deletions Modules/_threadmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ thread_bootstate_free(struct bootstate *boot, int decref)
Py_DECREF(boot->args);
Py_XDECREF(boot->kwargs);
}
PyMem_Free(boot);
PyMem_RawFree(boot);
}


Expand Down Expand Up @@ -1184,13 +1184,13 @@ thread_PyThread_start_new_thread(PyObject *self, PyObject *fargs)
return NULL;
}

struct bootstate *boot = PyMem_NEW(struct bootstate, 1);
struct bootstate *boot = PyMem_RawMalloc(sizeof(struct bootstate));
if (boot == NULL) {
return PyErr_NoMemory();
}
boot->tstate = _PyThreadState_New(interp);
if (boot->tstate == NULL) {
PyMem_Free(boot);
PyMem_RawFree(boot);
if (!PyErr_Occurred()) {
return PyErr_NoMemory();
}
Expand Down