gh-109721: Guard _testinternalcapi
imports in tests
#109722
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
test_cmd_line.py
only imports it without a guard incheck_pythonmalloc
, which is only used intest_pythonmalloc
, so marking it as@cpython_only
is good enougtest_import/__init__.py
already has several guards likerequires_singlephase_init
which implies@cpython_only
, so only aexcept ImportError
is neededtest_opcache
can be skipped without_testinternalcapi
, because most (all?) tests are cpython-only and require it_testinternalcapi
is imported without guards in some test modules #109721