gh-109627: duplicated smalll exit blocks need to be assigned jump target labels #109630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
type-bug
carljm
approved these changes
Sep 20, 2023
carljm
approved these changes
Sep 20, 2023
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @iritkatriel, I could not cleanly backport this to |
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Sep 20, 2023
…mp target labels (python#109630) (cherry picked from commit 9ccf054)
iritkatriel
added a commit
to iritkatriel/cpython
that referenced
this pull request
Sep 20, 2023
…mp target labels (python#109630) (cherry picked from commit 9ccf054)
|
GH-109632 is a backport of this pull request to the 3.12 branch. |
|
GH-109632 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 22, 2023
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109627.
In order to ensure that function exits have a line number, the compiler duplicates small exit blocks which (1) do not have a line number in any instruction and (2) have more than one predecessor. Since these blocks are jump targets (at least one predecessor reaches this block via a jump or exception), they need to have labels assigned to them. This was missing, and is added in this PR.