gh-107322: zipapp: Remove the suggestion to remove .dist-info directories #107296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly breaks importlib.metadata
wimglenn
changed the title
wimglenn
changed the title
|
@jaraco Might you know who can get some eyes on this? |
AA-Turner
approved these changes
Sep 8, 2023
AA-Turner
added
needs backport to 3.11
AA-Turner
changed the title
hugovk
approved these changes
Sep 11, 2023
jaraco
approved these changes
Sep 11, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2023
…irectories (pythonGH-107296) Removed zipapp suggestion to rm .dist-info subdirectories. This totally breaks importlib.metadata (cherry picked from commit 1ee50e2) Co-authored-by: wim glenn <[email protected]>
|
GH-109281 is a backport of this pull request to the 3.12 branch. |
|
GH-109282 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 11, 2023
…irectories (pythonGH-107296) Removed zipapp suggestion to rm .dist-info subdirectories. This totally breaks importlib.metadata (cherry picked from commit 1ee50e2) Co-authored-by: wim glenn <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Sep 12, 2023
…directories (GH-107296) (#109282) Co-authored-by: wim glenn <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 12, 2023
…directories (GH-107296) (#109281) gh-107322: zipapp: Remove the suggestion to remove .dist-info directories (GH-107296) Removed zipapp suggestion to rm .dist-info subdirectories. This totally breaks importlib.metadata (cherry picked from commit 1ee50e2) Co-authored-by: wim glenn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that this totally breaks
importlib.metadatausage.E.g. if you have an argparse
--versionin your app which usesimportlib.metadata.version("myapp"), but you've unlinked all the .dist-info metadata before making the zipapp, you'll get:We don't know if/when third party libraries want to look at their own package metadata, so I think this suggestion in the docs should be removed outright.