Skip to content

[3.7] bpo-24658: os.read() reuses _PY_READ_MAX (GH-10657) #10658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2018
Merged

[3.7] bpo-24658: os.read() reuses _PY_READ_MAX (GH-10657) #10658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8021,11 +8021,7 @@ os_read_impl(PyObject *module, int fd, Py_ssize_t length)
return posix_error();
}

#ifdef MS_WINDOWS
/* On Windows, the count parameter of read() is an int */
if (length > INT_MAX)
length = INT_MAX;
#endif
length = Py_MIN(length, _PY_READ_MAX);

buffer = PyBytes_FromStringAndSize((char *)NULL, length);
if (buffer == NULL)
Expand Down