gh-105908: fix barry_as_FLUFL future import
#105909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatbirdguythatuknownot
requested review from
markshannon and
iritkatriel
as code owners
|
Is there no test for this? |
I'm currently adding it. |
Eclips4
reviewed
Jun 19, 2023
Misc/NEWS.d/next/Core and Builtins/2023-06-19-11-04-01.gh-issue-105908.7oanny.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kirill Podoprigora <[email protected]>
iritkatriel
approved these changes
Jun 19, 2023
|
Thank you @thatbirdguythatuknownot . |
|
@thatbirdguythatuknownot there is a test failure in the "Address sanitizer" test. Is it due to this PR? |
It must be from |
|
Thanks! This change makes sense. |
|
Does this need to be backported to 3.12? |
|
Thanks @thatbirdguythatuknownot for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-105930 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 20, 2023
(cherry picked from commit 28187a9) Co-authored-by: Crowthebird <[email protected]>
JelleZijlstra
pushed a commit
that referenced
this pull request
Jun 20, 2023
…5930) (cherry picked from commit 28187a9) Co-authored-by: Crowthebird <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
compiler_setup(), theflagsparameter is a local struct that does not reflect changes to the pointer passed tonew_compiler(). Fix by making theflagsparameter a pointer to a struct instead of a struct.__future__importbarry_as_FLUFLdoes not work in the REPL anymore #105908