Skip to content

GH-104898: Add __slots__ to os.PathLike #104899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

GH-104898: Add __slots__ to os.PathLike #104899

merged 1 commit into from
May 25, 2023

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented May 24, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 24, 2023
Closed
@barneygale barneygale mentioned this pull request May 24, 2023
Closed
@barneygale barneygale requested a review from brettcannon May 24, 2023 21:55
brettcannon
brettcannon approved these changes May 25, 2023
View reviewed changes
@barneygale barneygale merged commit bd1b622 into python:main May 25, 2023
@barneygale
Copy link
Contributor Author

Thanks @brettcannon! Do you think this should be backported?

@merwok
Copy link
Member

merwok commented May 25, 2023

It’s not clearly a bugfix, so no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barneygale @merwok @brettcannon @bedevere-bot