gh-102105 Fix wording in filterfalse/quantify/filter #102189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OTheDev
reviewed
Feb 24, 2023
| @@ -398,7 +398,7 @@ loops that truncate the stream. | |||
| .. function:: filterfalse(predicate, iterable) | |||
|
|
|||
| Make an iterator that filters elements from iterable returning only those for | |||
| which the predicate is ``False``. If *predicate* is ``None``, return the items | |||
| which the predicate is false. If *predicate* is ``None``, return the items | |||
There was a problem hiding this comment.
False is also correct here; this change seems to be pedantic churn only, and has no real value, IMO. I'd keep the current text. The following sentence uses None; I don't see any reason not to use False here. I'd consider leaving this as it is.
There was a problem hiding this comment.
No, False explicitly means the Python object False, no other false objects. So that's incorrect here. The None case is different.
rhettinger
approved these changes
Feb 24, 2023
|
Thanks @pochmann for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-102219 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 24, 2023
…102189) (cherry picked from commit 81bf10e) Co-authored-by: Stefan Pochmann <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Feb 24, 2023
(cherry picked from commit 81bf10e) Co-authored-by: Stefan Pochmann <[email protected]>
JelleZijlstra
pushed a commit
to JelleZijlstra/cpython
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.