Skip to content

[3.11] GH-98363: Update batched() recipe in docs to match 3.12 #100323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2022
Merged

[3.11] GH-98363: Update batched() recipe in docs to match 3.12 #100323

merged 2 commits into from
Dec 18, 2022

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Dec 17, 2022 •
edited by bedevere-bot
Loading

@rhettinger rhettinger added docs Documentation in the Doc dir skip news labels Dec 17, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 17, 2022
Closed
hauntsaninja
hauntsaninja reviewed Dec 17, 2022
View reviewed changes
CAM-Gerlach
CAM-Gerlach approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective, FWIW. Should this be backported to 3.10 as well?

@CAM-Gerlach CAM-Gerlach mentioned this pull request Dec 18, 2022
Closed
@CAM-Gerlach
Copy link
Member

Also, I noticed that though this PR was made from your fork per the usual flow. there is an apparent duplicate https://github.com/python/cpython/tree/batched_recipe_tuple branch on the upstream cpython repo. Does that need to be there, or can it be removed? It's the final blocker to implementing the final step of python/core-workflow#460 on cpython. Thanks!

@rhettinger rhettinger merged commit 0918667 into python:3.11 Dec 18, 2022
@rhettinger rhettinger deleted the batched_recipe_tuple branch December 18, 2022 01:10
@rhettinger
Copy link
Contributor Author

@CAM-Gerlach Yes, go ahead and remove the other branch.

@CAM-Gerlach
Copy link
Member

Thanks, removed! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhettinger @CAM-Gerlach @hauntsaninja @bedevere-bot