remove deprecated urllib.request.URLopener/FancyURLopener

[PetterS]

BPO	40673
Nosy	@vstinner, @PetterS, @remilapeyre, @idomic

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-05-18.21:30:13.142>
labels = ['type-feature', 'library', '3.11']
title = 'remove deprecated urllib.request.URLopener/FancyURLopener'
updated_at = <Date 2021-11-23.13:31:04.736>
user = 'https://github.com/PetterS'

bugs.python.org fields:

activity = <Date 2021-11-23.13:31:04.736>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2020-05-18.21:30:13.142>
creator = 'Petter S'
dependencies = []
files = []
hgrepos = []
issue_num = 40673
keywords = []
message_count = 7.0
messages = ['369291', '369293', '369294', '369295', '369300', '369886', '406839']
nosy_count = 4.0
nosy_names = ['vstinner', 'Petter S', 'remi.lapeyre', 'Ido Michael']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40673'
versions = ['Python 3.11']

Linked PRs

• GH-84850: Remove urllib.request.URLopener and FancyURLopener #125739
• GH-84850: Improve whatsnew entry for [Fancy]URLopener removal #127032

[PetterS]

The following code crashes with TypeError:

URLopener().open("unknown_proxy://test")

the expected behavior is an OSError, which is normally raised for unknown protocols.

This implementation of directly calling a method called "unknown_proxy" is fragile and was recently the subject of a security issue: https://bugs.python.org/issue35907 (CVE-2019-9948)

Would be good to make this more robust.

[PetterS]

I can fix this, but it does not have high priority.

[remilapeyre]

URLOpener has been deprecated since Python3.3 (https://github.com/python/cpython/blob/master/Lib/urllib/request.py#L1703-L1705) maybe it should just be removed from the codebase?