Closed
Description
Logs show the following exception after adding a test-with-buildbot
label:
2025-02-26 13:41:00+0000 [HTTP11ClientProtocol (BufferingTLSTransport),client] adding changes from web hook
Traceback (most recent call last):
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
result = context.run(
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
return g.throw(self.value.with_traceback(self.tb))
File "/srv/buildbot/venv/lib/python3.9/site-packages/buildbot/www/change_hook.py", line 106, in getAndSubmitChanges
changes, src = yield self.getChanges(request)
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
result = context.run(
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
return g.throw(self.value.with_traceback(self.tb))
File "/srv/buildbot/venv/lib/python3.9/site-packages/buildbot/www/change_hook.py", line 171, in getChanges
changes, src = yield handler.getChanges(request)
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
result = context.run(
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
return g.throw(self.value.with_traceback(self.tb))
File "/srv/buildbot/venv/lib/python3.9/site-packages/buildbot/www/hooks/github.py", line 92, in process
result = yield handler(payload, event_type)
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2013, in _inlineCallbacks
result = context.run(
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/python/failure.py", line 467, in throwExceptionIntoGenerator
return g.throw(self.value.with_traceback(self.tb))
File "/srv/buildbot/master/custom/pr_testing.py", line 332, in handle_pull_request
yield self._remove_label_and_comment(payload, label)
File "/srv/buildbot/venv/lib/python3.9/site-packages/twisted/internet/defer.py", line 2017, in _inlineCallbacks
result = context.run(gen.send, result)
File "/srv/buildbot/master/custom/pr_testing.py", line 87, in _remove_label_and_comment
pr_number = payload["issue"]["number"]
builtins.KeyError: 'issue'
Looks like that can be ["pull_request"]["number"]
.
I'll prepare a fix tomorrow if no one beats me to it.
Metadata
Metadata
Assignees
Labels
No labels