Realtime: cleanup factory method use #1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conengmo
requested changes
Apr 17, 2024
README.rst
Outdated
| @@ -81,3 +81,4 @@ Plugins: | |||
|
|
|||
| - https://github.com/onaci/folium-glify-layer: provide fast webgl rendering for large GeoJSON FeatureCollections | |||
| - https://github.com/carlosign/Folium.ControlCredits-Plugin: displaying credits in the corner. Display an image/logo, clicking it will expand to show a brief message with credits and links. | |||
| - https://github.com/JohnyCarrot/folium-geocoder-own-locations: a geocoder that accepts a list of suggestions at creation time. | |||
There was a problem hiding this comment.
could you add this as a separate PR? Best to have one 'thing' per PR. Otherwise tracking changes becomes a mess.
There was a problem hiding this comment.
Done: see #1927
hansthen
force-pushed
the
cleanup_factory
branch
from
5fd84e3 to
41e0004
Compare
Conengmo
changed the title
Conengmo
approved these changes
Apr 17, 2024
hansthen
added a commit
to hansthen/folium
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No
newis required