Skip to content

Remove deprecated tilesets #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2020

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented May 24, 2020

Clean up some of the built-in tileset templates.

Cloudmade no longer provides a public API. Our version of the Mapbox API is outdated, see #922

It's quite trivial for users to keep using Mapbox, they just have to pass the API url to the tiles argument. I reckon that's what current Mapbox users are already doing. So I don't see a need to update our template to v4.

We can also drop the API_key argument which was only used for Cloudmade and Mapbox.

Raise an exception if a users tries to use the removed tilesets, providing help on how to resolve.

Closes #922

@Conengmo Conengmo merged commit 79403fe into python-visualization:master May 30, 2020
@Conengmo Conengmo deleted the cleanup-tilesets branch May 30, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update MapBox to v4 ?
1 participant