This repository was archived by the owner on Oct 8, 2024. It is now read-only.
Build zlib on Linux as well #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Do you know what's up with the macOS builds? |
Contributor
See #205 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-pillow/Pillow#5544 points out that our Linux wheels contain zlib 1.2.3.
Despite
pillow-wheels/config.sh
Line 10 in fd81da7
We're only currently upgrading it on macOS.
pillow-wheels/config.sh
Lines 48 to 51 in fd81da7
So this PR runs
build_new_zlibon Linux as well.There is a warning attached to this in multibuild., but that would only be a warning for our build process, not for the end user.
See radarhere@874bb0a and https://github.com/radarhere/pillow-wheels/actions/runs/942830985#artifacts for an example of what this change outputs.