-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Support writing QOI images #9007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e6838ce to
6c546f8
Compare
for more information, see https://pre-commit.ci
If I look at https://qoiformat.org/qoi-specification.pdf, I see
|
Yes, just as the previous pixel value - it says nothing about adding it to the hash. (I'll look at the other stuff a bit later today, thanks) |
Fixed type hints
Removed qoi_ prefix from save argument
Co-authored-by: Andrew Murray <[email protected]>
Adds support for writing .qoi files.
In more details:
Unrelated note - the .qoi reading implementation incorrectly adds (0, 0, 0, 255) to _previously_seen_pixels at the start.
It should only be set on _previous_pixel.
However, I think this is benign since (0,0,0,255) has a different hash from (0,0,0,0) and a valid encoder won't encode (0,0,0,0) using non-0 hash values.