Skip to content

Reduce number of bytes read for PCX header #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 2 commits into from
Jun 10, 2025
Merged

Reduce number of bytes read for PCX header #9004

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
313969c
Removed unnecessary seek
radarhere Jun 9, 2025
7341e70
Reduced number of bytes read for header
radarhere Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/PIL/PcxImagePlugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def _open(self) -> None:
# header
assert self.fp is not None

s = self.fp.read(128)
s = self.fp.read(68)
if not _accept(s):
msg = "not a PCX file"
raise SyntaxError(msg)
Expand All @@ -66,6 +66,8 @@ def _open(self) -> None:
raise SyntaxError(msg)
logger.debug("BBox: %s %s %s %s", *bbox)

offset = self.fp.tell() + 60

# format
version = s[1]
bits = s[3]
Expand Down Expand Up @@ -102,7 +104,6 @@ def _open(self) -> None:
break
if mode == "P":
self.palette = ImagePalette.raw("RGB", s[1:])
self.fp.seek(128)

elif version == 5 and bits == 8 and planes == 3:
mode = "RGB"
Expand All @@ -128,9 +129,7 @@ def _open(self) -> None:
bbox = (0, 0) + self.size
logger.debug("size: %sx%s", *self.size)

self.tile = [
ImageFile._Tile("pcx", bbox, self.fp.tell(), (rawmode, planes * stride))
]
self.tile = [ImageFile._Tile("pcx", bbox, offset, (rawmode, planes * stride))]


# --------------------------------------------------------------------
Expand Down
Loading