Skip to content

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Apr 1, 2025

libtiff has started failing to build in main on WIndows - https://github.com/python-pillow/Pillow/actions/runs/14187037544/job/39744130790

This would be due to the recent release of cmake 4 - https://github.com/Kitware/CMake/releases/tag/v4.0.0

https://cmake.org/cmake/help/latest/release/4.0.html#deprecated-and-removed-features

Compatibility with versions of CMake older than 3.5 has been removed.

@hugovk hugovk added the automerge Automatically merge PRs that are ready label Apr 1, 2025
@hugovk hugovk added this to the 11.2.0 milestone Apr 1, 2025
@radarhere radarhere changed the title Allow cmake<4 when building libtiff Allow cmake<4 when building libavif and libtiff Apr 1, 2025
@radarhere radarhere merged commit 869aa58 into python-pillow:main Apr 1, 2025
84 of 86 checks passed
@radarhere radarhere deleted the tiff branch April 1, 2025 07:31
@hugovk
Copy link
Member

hugovk commented Apr 1, 2025

@radarhere
Copy link
Member Author

They mysteriously reverted to the 20250309.1.0 runner image. I reran the jobs and they passed this time.

If you'd like, #8855 adds rustup update to fix the problem even in the earlier runner image.

@hugovk
Copy link
Member

hugovk commented Apr 1, 2025

Thanks! Good to know we can restart it and hopefully get the newer runner.

I'll go ahead with the release without merging it to save a bunch of CI time, but we can merge it afterwards if we see it pop up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge PRs that are ready TIFF Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants