Fix file position desync when calling into libtiff #8560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
reviewed
Nov 20, 2024
Merged
radarhere
reviewed
Nov 20, 2024
Tests/test_libtiff_file_position.py
Outdated
| [ | ||
| "Tests/images/old-style-jpeg-compression-no-samplesperpixel.tif", | ||
| "Tests/images/old-style-jpeg-compression.tif", | ||
| ], |
Member
There was a problem hiding this comment.
Is there anything different between these two files that means that one might conceivably fail where the other wouldn't? Or are you just testing two to be thorough?
Contributor
Author
There was a problem hiding this comment.
No, these were just the files that reproduced the issue
Co-authored-by: Andrew Murray <[email protected]>
Moved test
radarhere
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8559
Changes proposed in this pull request: