Skip to content

Conversation

@lysnikolaou
Copy link
Contributor

Fixes #8454.

Changes proposed in this pull request:

  • Introduce a mutex that needs to be held every time FT_New_Face or FT_Done_Face are called.
  • Upgrade pythoncapi_compat.h to the latest version.

@hugovk hugovk added the Free-threading PEP 703 support label Oct 24, 2024
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@nulano nulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anything here actually using the new changes in pythoncapi_compat.h?

There's no reason to stick with an old version, but I'm curious if there is a reason for updating it in what looks like an unrelated PR?

@lysnikolaou
Copy link
Contributor Author

Is anything here actually using the new changes in pythoncapi_compat.h?

There's no reason to stick with an old version, but I'm curious if there is a reason for updating it in what looks like an unrelated PR?

No, upgrading pythoncapi_compat was actually needed in an earlier version of my patch, but I actually ended up not needing the new stuff.

However, I thought that it might be okay for the header to be upgraded anyway, that's why I left it in.

@radarhere radarhere merged commit 9a4b3e0 into python-pillow:main Oct 26, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Free-threading PEP 703 support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault under free-threaded build

4 participants