Skip to content

Improved copying imagequant libraries #8420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 1 commit into from
Sep 28, 2024
Merged

Improved copying imagequant libraries #8420

hugovk merged 1 commit into from
Sep 28, 2024

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Sep 27, 2024 •
edited
Loading

#8407 updated the path to shared libraries in libimagequant to allow for usr/lib64.

I've made two improvements here.

  1. The previous PR didn't update the path to copy from for the caching mechanism. This is inconsistent, and might cause problems one day.
  2. I found that the path for Debian is usr/lib/x86_64-linux-gnu. Rather than adding a third possible path, I've used find to allow for the path to vary.

@radarhere radarhere changed the title Shared imagequant libraries may be located within usr/lib64 Improved copying imagequant libraries Sep 28, 2024
@hugovk hugovk merged commit 58ef920 into python-pillow:main Sep 28, 2024
@radarhere radarhere deleted the libimagequant_lib64 branch September 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Dependency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radarhere @hugovk