Skip to content

Conversation

@akx
Copy link
Contributor

@akx akx commented Aug 6, 2024

For easier installation of those requirements outside tox.

@radarhere
Copy link
Member

And the reason that you're not just moving these into .ci/requirements-mypy.txt is in case someone wants to use a type-checking system other than mypy?

That might be reasonable, sure, I just hope that we're not going to start down the road of trying to satisfy more than one type-checking tool at the same time.

@akx
Copy link
Contributor Author

akx commented Aug 6, 2024

And the reason that you're not just moving these into .ci/requirements-mypy.txt is in case someone wants to use a type-checking system other than mypy?

No, it was because I wasn't sure if there was a reason for these to have been in the toxfile to begin with 😅

I can absolutely put them in requirements-mypy.txt too!

@radarhere
Copy link
Member

#7813 moved mypy into requirements-mypy.txt so it could be automatically updated.

I think having everything in one file sounds simplest. @hugovk ?

@hugovk
Copy link
Member

hugovk commented Aug 6, 2024

All in requirements-mypy.txt sounds good, that means you can also easily do stuff like:

pip install -r requirements-mypy.txt
mypy src Tests

For easier installation outside tox
@akx
Copy link
Contributor Author

akx commented Aug 7, 2024

Moved 'em all to requirements-mypy.txt.

@radarhere
Copy link
Member

Thanks

@radarhere radarhere merged commit 11b4df3 into python-pillow:main Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants