Skip to content

Conversation

@lysnikolaou
Copy link
Contributor

No description provided.

@hugovk hugovk added the Free-threading PEP 703 support label Jul 17, 2024
@hugovk hugovk merged commit b6868f3 into python-pillow:main Jul 17, 2024
@radarhere
Copy link
Member

I expect we will revert this before the next release - it is helpful to be able to manually trigger all of the wheel jobs before a release, to increase confidence that everything will work correctly.

@lysnikolaou
Copy link
Contributor Author

I expect we will revert this before the next release - it is helpful to be able to manually trigger all of the wheel jobs before a release, to increase confidence that everything will work correctly.

Good point. Maybe it makes sense to add an input to the workflow so that someone can choose whether to build the emulated wheels or not. I can open a PR if you think that's a good idea.

@radarhere
Copy link
Member

Maybe it makes sense to add an input to the workflow

At that point, it's probably simplest to split the workflow into two.

Do you anticipate frequently wanting to manually trigger an upload to scientific python? I would have thought the motivation for this PR was just to temporarily speed things up while sorting out #8236

@lysnikolaou
Copy link
Contributor Author

Do you anticipate frequently wanting to manually trigger an upload to scientific python?

No, not at all. Most nightly uploads are supposed to be happening through the cron job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Free-threading PEP 703 support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants