Remove WebP support without anim, mux/demux, and with buggy alpha #8213

homm · 2024-07-07T18:57:05Z

Rationale

There is a bunch of legacy code which is not even tested:
https://app.codecov.io/gh/python-pillow/Pillow/pull/8211/blob/src/PIL/WebPImagePlugin.py#L50
All Pillow capabilities require libwebp 0.5.0, which was released in Dec 2015.

Removed APIs

features.check("transp_webp"): Deprecated, will be removed in 12
features.check("webp_mux"): Deprecated, will be removed in 12
features.check("webp_anim"): Deprecated, will be removed in 12
_webp.WebPDecoderVersion(): not documented and has alternative: _webp.webpdecoder_version
_webp.WebPDecoderBuggyAlpha(): not documented
_webp.HAVE_WEBPANIM: not documented
_webp.WebPDecode(): obsolete webp decoder
webpmux compiling options

src/_webp.c

homm · 2024-07-07T19:00:59Z

winbuild/build_prepare.py

        "build": [
            *cmds_cmake(
-                "webp webpdemux webpmux",
+                "webp webpmux webpdemux",


Preserve order like in other places

homm · 2024-07-07T19:02:08Z

src/_webp.c

 * very early versions had some significant differences, so we require later
 * versions, before enabling animation support.
 */
-#if WEBP_MUX_ABI_VERSION >= 0x0104 && WEBP_DEMUX_ABI_VERSION >= 0x0105


This ABI versions actually was never released, v0.5.0 have 0x0106 and 0x0107:

https://github.com/webmproject/libwebp/blob/v0.5.0/src/webp/mux.h#L24
https://github.com/webmproject/libwebp/blob/v0.5.0/src/webp/demux.h#L58

IIRC, some of that was for webp as shipped in debian derived distributions, now long deprecated.

radarhere · 2024-07-08T11:16:14Z

features.check("transp_webp")
features.check("webp_mux")
features.check("webp_anim")

Removing these without warning sounds a little concerning to me - using them doesn't mean someone is using software from 9 years ago, merely that they are supporting the idea of other people doing so.

homm · 2024-07-08T16:22:42Z

@radarhere pretty reasonable. I've moved them back.

Tests/test_file_webp_animated.py

Tests/test_file_webp_metadata.py

setup.py

src/_webp.c

docs/releasenotes/11.0.0.rst

homm · 2024-07-28T13:36:23Z

Rebased

src/PIL/features.py

src/_webp.c

Removed: _webp.WebPDecode _webp.HAVE_WEBPANIM features.webp_anim

Improve compiler advice Update src/PIL/features.py

homm · 2024-08-13T05:37:38Z

Rebased and squashed some commits

homm · 2024-08-13T05:39:47Z

@radarhere could you look at this? I'm not experienced with mypy at all
https://github.com/python-pillow/Pillow/actions/runs/10364204279/job/28689074326?pr=8213

src/PIL/features.py

Co-authored-by: Andrew Murray <[email protected]>

Suggestions for deprecating older WebP versions

homm commented Jul 7, 2024

View reviewed changes

radarhere added the WebP label Jul 8, 2024

radarhere changed the title ~~Remove webp support without anim, mux/demux, and with buggy alpha~~ Remove WebP support without anim, mux/demux, and with buggy alpha Jul 8, 2024

homm force-pushed the webp-require-anim branch from 924b4fe to 709f103 Compare July 8, 2024 16:10

nulano reviewed Jul 15, 2024

View reviewed changes

Tests/test_file_webp_animated.py Outdated Show resolved Hide resolved

Tests/test_file_webp_metadata.py Outdated Show resolved Hide resolved

setup.py Outdated Show resolved Hide resolved

src/_webp.c Show resolved Hide resolved

homm requested a review from nulano July 16, 2024 11:01

nulano approved these changes Jul 16, 2024

View reviewed changes

radarhere reviewed Jul 17, 2024

View reviewed changes

docs/releasenotes/11.0.0.rst Outdated Show resolved Hide resolved

radarhere reviewed Jul 17, 2024

View reviewed changes

docs/releasenotes/11.0.0.rst Outdated Show resolved Hide resolved

radarhere reviewed Jul 17, 2024

View reviewed changes

docs/releasenotes/11.0.0.rst Outdated Show resolved Hide resolved

radarhere added the Needs Rebase label Jul 19, 2024

radarhere mentioned this pull request Jul 20, 2024

Remove unnecessary pymode variable #8247

Closed

homm removed the Needs Rebase label Jul 28, 2024

radarhere reviewed Aug 12, 2024

View reviewed changes

src/PIL/features.py Outdated Show resolved Hide resolved

radarhere reviewed Aug 12, 2024

View reviewed changes

src/_webp.c Outdated Show resolved Hide resolved

radarhere mentioned this pull request Aug 12, 2024

Moved line after early return uploadcare/pillow-simd#141

Merged

homm and others added 6 commits August 13, 2024 09:24

Require webpmux and webpdemux

c1e8375

Remove _webp.WebPDecoderBuggyAlpha and _webp.HAVE_TRANSPARENCY

9bed5b4

Remove webp animations flags and conditions

a346899

Removed: _webp.WebPDecode _webp.HAVE_WEBPANIM features.webp_anim

Bring back removed features, add deprecations and Release notes

56ca359

Remove WebP versions notes from docs

6180abc

Moved line after early return

924df9e

Improve compiler advice Update src/PIL/features.py

homm force-pushed the webp-require-anim branch from 41c1047 to 924df9e Compare August 13, 2024 05:35

radarhere reviewed Aug 13, 2024

View reviewed changes

src/PIL/features.py Outdated Show resolved Hide resolved

Update features type

93ce9ce

Co-authored-by: Andrew Murray <[email protected]>

radarhere added 3 commits August 13, 2024 19:03

Removed unnecessary variable

5546994

Simplified code

f3aec6d

Use relative import

c7e6289

radarhere mentioned this pull request Aug 13, 2024

Suggestions for deprecating older WebP versions uploadcare/pillow-simd#142

Merged

radarhere added the Deprecation Feature that will be removed in the future label Aug 13, 2024

radarhere and others added 5 commits August 14, 2024 18:35

Updated test name

ba82dff

Animation support is no longer conditionally enabled

66319fc

Updated documentation

45552b5

Test deprecation warnings

359d759

Merge pull request #142 from radarhere/webp-require-anim

4d544da

Suggestions for deprecating older WebP versions

radarhere approved these changes Aug 14, 2024

View reviewed changes

homm merged commit 35a70e4 into python-pillow:main Aug 14, 2024

homm deleted the webp-require-anim branch August 14, 2024 11:27

Yay295 mentioned this pull request Aug 14, 2024

Use (void) for empty function parameters #8002

Merged

radarhere added a commit to radarhere/Pillow that referenced this pull request Sep 10, 2024

Added release notes for python-pillow#8213

7a20f33

radarhere added a commit to radarhere/Pillow that referenced this pull request Sep 10, 2024

Added release notes for python-pillow#8213

fea3e0d

radarhere mentioned this pull request Oct 11, 2024

Always raise warnings for deprecated feature checks #8459

Merged

radarhere mentioned this pull request Jul 1, 2025

Remove deprecations for Pillow 12.0.0 #9053

Merged

radarhere mentioned this pull request Jul 8, 2025

Remove reference to libtiff 3.x #9072

Merged

Uh oh!

Remove WebP support without anim, mux/demux, and with buggy alpha #8213

Remove WebP support without anim, mux/demux, and with buggy alpha #8213

Uh oh!

Conversation

homm commented Jul 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale

Removed APIs

Uh oh!

Uh oh!

homm Jul 7, 2024

Choose a reason for hiding this comment

Uh oh!

homm Jul 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wiredfool Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

radarhere commented Jul 8, 2024

Uh oh!

homm commented Jul 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

homm commented Jul 28, 2024

Uh oh!

Uh oh!

Uh oh!

homm commented Aug 13, 2024

Uh oh!

homm commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

homm commented Jul 7, 2024 •

edited

Loading

homm Jul 7, 2024 •

edited

Loading

homm commented Aug 13, 2024 •

edited

Loading