Do not use percent format in strings

[radarhere]

Fixes the failures in #8044

Converts several percent format strings to f-strings.

There is also a percent format inside a multiline string - I think the neatest solution is just to break the multiline string.

[Yay295]

created radarhere#25 for the PdfParser change

[radarhere]

Suggested change

	msg = (
	"bad or missing Length in stream dict "
	f"({result.get(b'Length')})"
	)
	stream_len = result.get(b"Length")
	msg = f"bad or missing Length in stream dict ({stream_len})"

radarhere#25 feels that error message should fit onto one line. The change above this would be my suggestion for that goal.

The suggestion from the PR is

stream_len_str = result.get(b"Length")
try:
	stream_len = int(stream_len_str)
except (TypeError, KeyError, ValueError) as e:
	msg = f"bad or missing Length in stream dict ({stream_len_str})"
	raise PdfFormatError(msg) from e

I think that makes the code harder to read, because, if you ignore the exception, there's more to understand.

[nulano]

My suggestion would be radarhere#25 (comment):

try:
	stream_len_str = result.get(b"Length")
	stream_len = int(stream_len_str)
except (TypeError, KeyError, ValueError) as e:
	msg = f"bad or missing Length in stream dict ({stream_len_str})"
	raise PdfFormatError(msg) from e

[radarhere]

Ok, I've pushed that - minus the KeyError, because now that result[b"Length"] is gone, it will no longer happen. int(None) will instead raise a TypeError.

[hugovk]

Can we put this in a variable outside the string, then make this an f-string?

[radarhere]

Ok, I've pushed a commit. It did require escaping brackets though.