Skip to content

Conversation

@radarhere
Copy link
Member

Follow up to #7975

  • I missed a place where WRITE_LIBTIFF is assigned directly in the tests, rather than using monkeypatch instead.
  • In parametrizing tests, I forgot that libtiff_support_custom_tags is only present if libtiff support is present. While @skip_unless_feature("libtiff") is there on this test file, the parametrize conditions are still evaluated, so if libtiff support is absent, this causes an error. I've used getattr to fix this.

@hugovk hugovk merged commit 1c21cd4 into python-pillow:main Apr 22, 2024
@radarhere radarhere deleted the libtiff branch April 22, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants