Skip to content

Deprecate support for libtiff < 4 #7998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 4 commits into from
Apr 22, 2024
Merged

Deprecate support for libtiff < 4 #7998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
023d017
Deprecate libtiff < 4
radarhere Apr 22, 2024
e144e41
Updated wording
radarhere Apr 22, 2024
2e1d2b2
Updated deprecation message
radarhere Apr 22, 2024
5a0a288
Added release notes
radarhere Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/deprecations.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ ImageMath eval()
``ImageMath.eval()`` has been deprecated. Use :py:meth:`~PIL.ImageMath.lambda_eval` or
:py:meth:`~PIL.ImageMath.unsafe_eval` instead.

Support for libtiff earlier than 4
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

.. deprecated:: 10.4.0

Support for libtiff earlier than 4 has been deprecated. Upgrade to a newer version of
libtiff instead.

Removed features
----------------

Expand Down
4 changes: 4 additions & 0 deletions src/PIL/TiffImagePlugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
from ._binary import i16be as i16
from ._binary import i32be as i32
from ._binary import o8
from ._deprecate import deprecate
from .TiffTags import TYPES

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -276,6 +277,9 @@
b"II\x2B\x00", # BigTIFF with little-endian byte order
]

if not getattr(Image.core, "libtiff_support_custom_tags", True):
deprecate("Support for libtiff earlier than 4", 12)


def _accept(prefix: bytes) -> bool:
return prefix[:4] in PREFIXES
Expand Down