Skip to content

Added type hints to additional tests #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radarhere merged 3 commits into from
Feb 20, 2024
Merged

Added type hints to additional tests #7816

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e39765d
Added type hints
radarhere Feb 20, 2024
a655d76
Simplified type hints
radarhere Feb 20, 2024
7200f47
Renamed argument
radarhere Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions Tests/test_imagecms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import shutil
from io import BytesIO
from pathlib import Path
from typing import Any

import pytest

Expand Down Expand Up @@ -336,25 +337,13 @@ def test_extended_information() -> None:
p = o.profile

def assert_truncated_tuple_equal(
tup1: tuple[tuple[float, float, float], ...] | tuple[float],
tup2: (
tuple[tuple[tuple[float, float, float], ...], ...]
| tuple[tuple[float, float, float], ...]
| tuple[float]
),
digits: int = 10,
tup1: tuple[Any, ...], tup2: tuple[Any, ...], digits: int = 10
) -> None:
# Helper function to reduce precision of tuples of floats
# recursively and then check equality.
power = 10**digits

def truncate_tuple(
tuple_or_float: (
tuple[tuple[tuple[float, float, float], ...], ...]
| tuple[tuple[float, float, float], ...]
| tuple[float, ...]
)
) -> tuple[tuple[float, ...], ...]:
def truncate_tuple(tuple_or_float: tuple[Any, ...]) -> tuple[Any, ...]:
Copy link
Member

@hugovk hugovk Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is called tuple_or_float but typed only as a tuple.

Do we ever call it as a float? If not, shall we rename it?

Copy link
Member Author

@radarhere radarhere Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit to rename it to tuple_value.

return tuple(
(
truncate_tuple(val)
Expand Down