Fixed reading FLI/FLC images with a prefix chunk #7804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please could you add a test that fails without the fix, and passes with it? |
Contributor
Author
|
This is reproducible with this sample : https://samples.ffmpeg.org/fli-flc/2422.FLC from PIL import Image, ImageFile
ImageFile.LOAD_TRUNCATED_IMAGES = True
im = Image.open("2422.FLC")
im.seek(15)
im.save('frame15.png')You get garbage without the patch and a clean image with the patch |
Member
|
Can you write a unit test, with an image that can be contributed under Pillow's licence? A unit test helps ensure this doesn't break in the future. |
radarhere
changed the title
Contributor
Author
|
test added |
radarhere
approved these changes
Feb 22, 2024
hugovk
reviewed
Feb 22, 2024
radarhere
reviewed
Feb 22, 2024
radarhere
reviewed
Feb 22, 2024
radarhere
reviewed
Feb 22, 2024
radarhere
reviewed
Feb 22, 2024
radarhere
reviewed
Feb 22, 2024
radarhere
approved these changes
Feb 22, 2024
Member
|
Thank you! |
radarhere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix FLC decoder for files with prefix chunk
without the seek() the decoder continues to read bytes in the prefixchunk and have zero chance to find the 0xF1FA magic number ut needs just after