Skip to content

Match mask size to pasted image size in GifImagePlugin #7779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 1 commit into from
Mar 1, 2024
Merged

Match mask size to pasted image size in GifImagePlugin #7779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Tests/test_file_gif.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,6 +1105,21 @@ def im_generator(ims):
assert reread.n_frames == 10


def test_append_different_size_image(tmp_path: Path) -> None:
out = str(tmp_path / "temp.gif")

im = Image.new("RGB", (100, 100))
bigger_im = Image.new("RGB", (200, 200), "#f00")

im.save(out, save_all=True, append_images=[bigger_im])

with Image.open(out) as reread:
assert reread.size == (100, 100)

reread.seek(1)
assert reread.size == (100, 100)


def test_transparent_optimize(tmp_path: Path) -> None:
# From issue #2195, if the transparent color is incorrectly optimized out, GIF loses
# transparency.
Expand Down
4 changes: 1 addition & 3 deletions src/PIL/GifImagePlugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,9 +649,7 @@ def _write_multiple_frames(im, fp, palette):
if "transparency" in encoderinfo:
# When the delta is zero, fill the image with transparency
diff_frame = im_frame.copy()
fill = Image.new(
"P", diff_frame.size, encoderinfo["transparency"]
)
fill = Image.new("P", delta.size, encoderinfo["transparency"])
if delta.mode == "RGBA":
r, g, b, a = delta.split()
mask = ImageMath.eval(
Expand Down