Added type hints to Tests/test_font_*.py #7743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Jan 22, 2024
nulano
reviewed
Jan 22, 2024
|
|
||
| def test_leak(self): | ||
| def test_leak(self) -> None: | ||
| default_font = ImageFont.load_default() |
Tests/test_font_pcf_charsets.py
Outdated
| fontname = "Tests/fonts/ter-x20b.pcf" | ||
|
|
||
| charsets = { | ||
| charsets: dict[str, dict[str, int | str]] = { |
Contributor
There was a problem hiding this comment.
You can remove the assert isinstance(...) calls if you use a TypedDict subclass for the value.
Member
Author
There was a problem hiding this comment.
Ok, I've pushed a commit for this.
Viicos
reviewed
Jan 23, 2024
Tests/test_font_pcf.py
Outdated
|
|
||
|
|
||
| def save_font(request, tmp_path): | ||
| def save_font(request: pytest.FixtureRequest, tmp_path: PosixPath) -> str: |
Member
Author
There was a problem hiding this comment.
Ok, I've pushed a commit to update it, both the changes from here and #7732
hugovk
reviewed
Jan 23, 2024
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.