Skip to content

Added type hints to ImageMath #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 3 commits into from
Jan 11, 2024
Merged

Added type hints to ImageMath #7707

hugovk merged 3 commits into from
Jan 11, 2024

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Jan 10, 2024 •
edited by hugovk
Loading

Helps #2625.

hugovk
hugovk reviewed Jan 10, 2024
View reviewed changes
src/PIL/ImageMath.py Outdated
compiled_code = compile(expression, "<string>", "eval")

def scan(code):
def scan(code) -> None:
Copy link
Member

@hugovk hugovk Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What type is code?

Copy link
Member Author

@radarhere radarhere Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit.

Copy link
Member

@hugovk hugovk Jan 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code's type is CodeType :D

radarhere and others added 2 commits January 10, 2024 23:36
@hugovk hugovk merged commit d6d6c7c into python-pillow:main Jan 11, 2024
@radarhere radarhere deleted the type_hints_imagemath branch January 11, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

Assignees

No one assigned

Labels

Type hints

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radarhere @hugovk