Skip to content

Rename x64 to AMD64 in winbuild #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
radarhere merged 5 commits into from
Jan 5, 2024
Merged

Rename x64 to AMD64 in winbuild #7693

radarhere merged 5 commits into from
Jan 5, 2024

Conversation

@nulano
Copy link
Contributor

@nulano nulano commented Jan 4, 2024 •
edited
Loading

Suggested in #7691 (comment)

Changes proposed in this pull request:

  • Rename x64 to AMD64 in winbuild.
  • Use CMake build of libwebp instead of NMake build: It seems to be more actively maintained and avoids the need for specifying the arch (which is used incorrectly in the nmake build anyway).

@nulano nulano mentioned this pull request Jan 4, 2024
Merged
hugovk
hugovk approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@radarhere radarhere merged commit f98fc9b into python-pillow:main Jan 5, 2024
@nulano nulano deleted the winbuild-amd64 branch January 5, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Assignees

No one assigned

Labels

Build Windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nulano @hugovk @radarhere