Skip to content

Added trusted PyPI publishing #7616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radarhere merged 10 commits into from
Dec 26, 2023
Merged

Added trusted PyPI publishing #7616

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cbab3a5
Removed "Success" job, as this is not used in mergify
radarhere Dec 14, 2023
6693046
Added trusted PyPI publishing
radarhere Dec 14, 2023
c81beb5
Updated step name
radarhere Dec 14, 2023
808f312
Updated environment name
radarhere Dec 15, 2023
fc1cf9f
Published to Test PyPI
radarhere Dec 19, 2023
97c2b66
Updated actions/upload-artifact to v4
radarhere Dec 24, 2023
2b806c5
Removed trailing dash
radarhere Dec 24, 2023
4de1765
Merge branch 'main' into pypi
radarhere Dec 26, 2023
a66fbb9
Updated Windows artifact name
radarhere Dec 26, 2023
043e13d
Revert "Published to Test PyPI"
radarhere Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 23 additions & 12 deletions .github/workflows/wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ jobs:
CIBW_TEST_SKIP: "*-macosx_arm64"
MACOSX_DEPLOYMENT_TARGET: ${{ matrix.macosx_deployment_target }}

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: dist
name: dist-${{ matrix.os }}-${{ matrix.archs }}${{ matrix.manylinux && format('-{0}', matrix.manylinux) }}
path: ./wheelhouse/*.whl

windows:
Expand Down Expand Up @@ -154,9 +154,9 @@ jobs:
shell: cmd

- name: Upload wheels
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
name: dist-${{ matrix.arch }}
path: ./wheelhouse/*.whl

- name: Upload fribidi.dll
Expand All @@ -179,17 +179,28 @@ jobs:

- run: make sdist

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: dist
name: dist-sdist
path: dist/*.tar.gz

success:
permissions:
contents: none
pypi-publish:
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
needs: [build, windows, sdist]
runs-on: ubuntu-latest
name: Wheels Successful
name: Upload release to PyPI
environment:
name: release-pypi
url: https://pypi.org/p/Pillow
Comment on lines +192 to +194
Copy link
Member

@hugovk hugovk Dec 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's failing because we don't have an env set-up yet? Shall we try without, and we can always add back later?

Suggested change
environment:
name: release-pypi
url: https://pypi.org/p/Pillow

permissions:
id-token: write
steps:
- name: Success
run: echo Wheels Successful
- uses: actions/download-artifact@v4
with:
pattern: dist-*
path: dist
merge-multiple: true
- name: Publish to PyPI
uses: pypa/gh-action-pypi-publish@release/v1
with:
repository-url: https://test.pypi.org/legacy/