Skip to content

Prefer screenshots using XCB over gnome-screenshot #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 3 commits into from
May 14, 2023
Merged

Prefer screenshots using XCB over gnome-screenshot #7143

hugovk merged 3 commits into from
May 14, 2023

Conversation

@nulano
Copy link
Contributor

@nulano nulano commented May 8, 2023 •
edited
Loading

Alternative to #7139

From #7100 (comment)

Is the problem just a user trying to ignore gnome-screenshot when it is installed in favour of Image.core.grabscreen_x11? If so, then ImageGrab.grab(xdisplay=":0") should be sufficient with the current version of Pillow.

[...] I have just tested setting xdisplay=':0', and it ran on my end without any white flash. I believe this usage needs to be tested across different platforms. If the test is successful, it should be set as the default option. [...]

@nulano nulano mentioned this pull request May 8, 2023
Closed
nulano
nulano commented May 8, 2023
View reviewed changes
src/PIL/ImageGrab.py
if bbox:
im = im.crop(bbox)
return im
except OSError:
Copy link
Contributor Author

@nulano nulano May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original error in #6312 was:

builtins.OSError: X get_image failed: error 8 (73, 0, 1315)

radarhere
radarhere reviewed May 8, 2023
View reviewed changes
@radarhere radarhere mentioned this pull request May 11, 2023
Merged
@hugovk hugovk merged commit 34ff170 into python-pillow:main May 14, 2023
@nulano nulano deleted the imagegrab-prefer-xcb branch May 14, 2023 21:05
@radarhere radarhere mentioned this pull request May 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radarhere radarhere radarhere approved these changes

Assignees

No one assigned

Labels

Linux Screen grab

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nulano @radarhere @hugovk