-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Release refinement #7074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release refinement #7074
Conversation
| and copy into `dist/` | ||
| and copy into `dist/`. For example using [GitHub CLI](https://github.com/cli/cli): | ||
| ```bash | ||
| gh release download --dir dist --pattern "*.whl" --repo python-pillow/pillow-wheels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gather you were thinking that this command would be run from the main repository, so that all of the files would be in one neat 'dist' directory.
However, in the previous point, the user cloned and navigated into pillow-wheels. So I feel like this is confusing. It would be good to either clarify that this should be run from the main repository, or if this is run from pillow-wheels, then --repo python-pillow/pillow-wheels is unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, I ran both these commands from the main repo, and agree this is confusing. Will clarify!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added cb68187 (and rebased in the PyQt workaround).
Co-authored-by: Andrew Murray <[email protected]>
60c4ab3 to
cb68187
Compare
Some updates to the release checklist, I followed these for 9.5.0.
First, I moved the
git push --allfrom near the start (after removing.dev0from the version and updatingCHANGES.rst), to near the end (after incrementing and adding.dev0to the version).The reason: the CI does a lot of building during releases and there's a lot of waiting around for the release manager. We only need the tags pushed early to build the Windows wheels via
git push --tags. The Linux and macOS wheels are built using their own dedicated wheel builder. Thegit push --alljust delays the CI from building all these wheels.So
git push --allwhich pushesmainand9.5.xcan come after all the wheel building.Next, during the "Binary Distributions" stage, it says to download the Windows wheels (once they're ready); then do some things to kick off the macOS and Linux wheel builder and download once ready.
Let's flip the order. Even if Windows wheels were ready (and they won't be yet), it's better to get the Mac/Linux CI queued up first.
Finally, I used the GitHub CLI
ghto download all the wheels before uploading them. Saves a lot of clicking in the UI! So let's include example commands for next time.(Aside:
gh co 1234is a really handy command for checking out a PR for local testing.)