Added saving RGBA images as PDFs #6925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Mar 12, 2023
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Thanks, let's add to the release notes (and regular docs if applicable).
radarhere
added a commit
to radarhere/Pillow
that referenced
this pull request
Mar 12, 2023
hugovk
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6924
As suggested in the issue, adds RGBA saving for PDFs through the JPXDecode filter with JPEG2000 image data.
However, when opening the result, I found that the background wasn't transparent, but black instead.
Testing converting a transparent PNG to JPEG2000 (
Image.open("Tests/images/transparent.png").save("transparent.jp2")), this is the case when simply saving JPEG2000 images. After looking at uclouvain/openjpeg#416 and https://github.com/uclouvain/openjpeg/blob/2d606701e8b7aa83f657d113c3367508e99bd12b/src/lib/openjp2/jp2.c#L2015-L2024 though, it turns out it was simply a case of telling OpenJPEG which channel was the alpha channel.