Relax ImageQt roundtrip check #6915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2023
Member
|
Thanks! I think this is acceptable to ease the CI pain. The problem still exists (and we have a better idea about it now!), but it seems to be limited to the interaction with Qt and I guess we've not had any complaints so far! And it's intermittent. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #6875
I ran the test suite repeatedly in GitHub Actions, and managed to have the
roundtrip()check fail during the RGB iteration of loop. Here is what the image looks like when it fails.There are three short lines of incorrect pixels in the image. If that is acceptable, then this PR relaxes the check so that this image would have passed.