Support arbitrary number of loaded modules on Windows #6761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the TKinter module loading function for Windows to support the rare (but possible) case of having more than 1024 modules loaded. This is an adaptation of the same fix that was added to Matplotlib in [PR #22445](matplotlib/matplotlib#22445).
Member
|
This is currently failing on Cygwin - https://github.com/python-pillow/Pillow/actions/runs/3549349093/jobs/5964443870#step:10:82
|
Contributor
Author
|
Huh, seems they also had that over there at Matplotlib. Added simple fix. |
Use break instead of goto
Member
|
@nulano would you like to review this? |
nulano
reviewed
Jan 4, 2023
Contributor
nulano
left a comment
nulano
left a comment
There was a problem hiding this comment.
The EnumProcessModules changes look good, but the error handling changes seem incorrect.
Co-authored-by: Ondrej Baranovič <[email protected]>
Co-authored-by: Ondrej Baranovič <[email protected]>
Co-authored-by: Ondrej Baranovič <[email protected]>
nulano
approved these changes
Jan 5, 2023
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the TKinter module loading function for Windows to support the rare (but possible) case of having more than 1024 modules loaded. This is an adaptation of the same fix that was added to Matplotlib in PR #22445 to solve their issue #22378. The same issue happens with Pillow under similar circumstances (error
RuntimeError: Could not find Tcl routineswithPIL.ImageTkmodule is loaded).