Skip to content

CVE-2007-4559 patch when building on Windows #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radarhere merged 4 commits into from
Nov 8, 2022
Merged

CVE-2007-4559 patch when building on Windows #6704

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e50a3a2
Adding tarfile member sanitization to extractall()
TrellixVulnTeam Oct 30, 2022
74c60b4
simplify patch, also check zipfile
nulano Oct 30, 2022
c10c6bf
use os.path.commonpath instead of os.path.commonprefix
nulano Nov 3, 2022
8947cbf
simplify code
nulano Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions winbuild/build_prepare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,11 +469,22 @@ def extract_dep(url, filename):
raise RuntimeError(ex)

print("Extracting " + filename)
sources_dir_abs = os.path.abspath(sources_dir)
if filename.endswith(".zip"):
with zipfile.ZipFile(file) as zf:
for member in zf.namelist():
member_abspath = os.path.abspath(os.path.join(sources_dir, member))
member_prefix = os.path.commonpath([sources_dir_abs, member_abspath])
if sources_dir_abs != member_prefix:
raise RuntimeError("Attempted Path Traversal in Zip File")
zf.extractall(sources_dir)
elif filename.endswith(".tar.gz") or filename.endswith(".tgz"):
with tarfile.open(file, "r:gz") as tgz:
for member in tgz.getmembers():
member_abspath = os.path.abspath(os.path.join(sources_dir, member.name))
member_prefix = os.path.commonpath([sources_dir_abs, member_abspath])
if sources_dir_abs != member_prefix:
raise RuntimeError("Attempted Path Traversal in Tar File")
tgz.extractall(sources_dir)
else:
raise RuntimeError("Unknown archive type: " + filename)
Expand Down