Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Sep 19, 2022

Fixes #6598

Changes proposed in this pull request:

@hugovk
Copy link
Member Author

hugovk commented Sep 19, 2022

Looks like Renovate uses Later.js for parsing the schedule:

renovatebot/renovate#11098 (comment)

This online tester suggests it doesn't like "on the third day of the month" but "on the 3rd day of the month" should be fine:

https://codepen.io/antonlydike/full/Kgygpr

@hugovk
Copy link
Member Author

hugovk commented Sep 19, 2022

Same thing parse error was happening in python-pillow/pillow-wheels#321 with "on the fourth day of the month" but it's now happy with "on the 4th day of the month" 👍

Similarly in python-pillow/docker-images#156 with "fifth" -> "5th".

Co-authored-by: Andrew Murray <[email protected]>
@hugovk hugovk merged commit d994813 into python-pillow:main Sep 20, 2022
@hugovk hugovk deleted the fix-renovate branch September 20, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action Required: Fix Renovate Configuration

2 participants