Skip to content

Conversation

@nulano
Copy link
Contributor

@nulano nulano commented Jun 20, 2022

Fixes #5816

Changes proposed in this pull request:

@nulano
Copy link
Contributor Author

nulano commented Jul 1, 2022

The docs indentation changes (5950269) are giving me warnings and change the produced formatting:

C:\Git\Pillow\docs\reference\ImageDraw.rst:440: WARNING: Explicit markup ends without a blank line; unexpected unindent.

Before 5950269:
image

After 5950269:
image

Without this PR:
image

@radarhere radarhere force-pushed the deprecate-getsize branch from 5950269 to 729fe6f Compare July 1, 2022 09:45
@radarhere
Copy link
Member

Thanks for catching that. I've updated the commit, and it should be fixed now.

@nulano
Copy link
Contributor Author

nulano commented Jul 1, 2022

Just to confirm, your intention is to put the deprecation message and suggested replacements in separate paragraphs, correct?

@radarhere
Copy link
Member

It fixes the warning you mentioned, and is how we've done it in the past.

@radarhere radarhere mentioned this pull request Jul 1, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge PRs that are ready Deprecation Feature that will be removed in the future

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getsize_multiline doesn't take into account characters that extend below the baseline

3 participants