Skip to content

Conversation

@radarhere
Copy link
Member

@radarhere radarhere commented Feb 23, 2022

GitHub Actions have started failing in main for Windows at the "Enable page verification" step.

# failing with PyPy3
- name: Enable heap verification
if: "!contains(matrix.python-version, 'pypy')"
run: "& 'C:\\Program Files (x86)\\Windows Kits\\10\\Debuggers\\x86\\gflags.exe' /p /enable $env:pythonLocation\\python.exe"

The error is

The term 'C:\Program Files (x86)\Windows Kits\10\Debuggers\x86\gflags.exe' is not recognized as a name of a cmdlet, function, script file, or executable program.

The problem started at the same time that the jobs switched from windows-2019 to windows-2022. It looks like windows-2022 does not have gflags.exe.

Taking advice from "How to enable PageHeap in Windows registry without having access to gflags.exe", this PR fixes the problem.

While this could now be used on PyPy, it takes an hour to do so, so I have continued to skip heap verification on PyPy.

@radarhere
Copy link
Member Author

Unrelated, I've added a commit to fix the currently failing MinGW builds.

@hugovk hugovk merged commit 14b9b59 into python-pillow:main Feb 24, 2022
@radarhere radarhere deleted the heap_verification branch February 24, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants