Enable heap verification without gflags #6089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions have started failing in main for Windows at the "Enable page verification" step.
Pillow/.github/workflows/test-windows.yml
Lines 140 to 143 in 4638c4f
The error is
The problem started at the same time that the jobs switched from windows-2019 to windows-2022. It looks like windows-2022 does not have gflags.exe.
Taking advice from "How to enable PageHeap in Windows registry without having access to gflags.exe", this PR fixes the problem.
While this could now be used on PyPy, it takes an hour to do so, so I have continued to skip heap verification on PyPy.