Merged _MODE_CONV typ into ImageMode as typestr #6057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/PIL/Image.py
Outdated
Comment on lines
214
to
217
| shape = (im.size[1], im.size[0]) | ||
| extra = len(m.bands) | ||
| if extra != 1: | ||
| shape += (extra,) |
Contributor
There was a problem hiding this comment.
Suggested change
| shape = (im.size[1], im.size[0]) | |
| extra = len(m.bands) | |
| if extra != 1: | |
| shape += (extra,) | |
| shape = (im.size[1], im.size[0]) # im.size[::-1] | |
| shape = shape if len(m.bands) == 1 else (*shape, len(m.bands)) |
Not sure if you find this syntax neater. Both options look viable to me.
Member
Author
There was a problem hiding this comment.
It does seem to be a matter of personal preference, but shape = shape looks odd to me.
I have clarified the first line slightly by changing it to (im.height, im.width).
Member
|
Thanks both! |
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5990
#5990 (comment) pointed out that the second value in
_MODE_CONV,extra, is the number of bands in the mode. Rather than writing those out in_MODE_CONV, this could instead be derived from ImageMode.The user in the issue would also like the NumPy typestr from
_MODE_CONVavailable through a public API, and suggested ImageMode. From an organisational point of view for Pillow's code, that seems like a more logical location for that information, and it would be neater, since it then means that_MODE_CONVcan be removed. The NumPy typestr could then be accessed by a user throughImageMode.getmode(mode).typestr.