Always save TIFF with contiguous planar configuration #5973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The forced libtiff writer cannot preserve it either? |
Member
Author
|
I don't know why the saved image is broken in main. However, https://www.awaresystems.be/imaging/tiff/tifftags/planarconfiguration.html
So it seems like a good idea to avoid the "separate" setting for the sake of compatibility of our created images. |
Contributor
|
Yeah, it's ok to play it safe for this case. I was just wondering if there was a remote chance of preserving the original image configuration, but unfortunately don't have the time to experiment right now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3622
If a TIFF image is opened with "separate" planar configuration, it is successfully read.
However, if that same image is saved, Pillow tries to keep the "separate" planar configuration from the input file, and the output image is broken.
This PR simply changes Pillow to always save "contiguous", and the output image is fixed.